Sub wird 2 mal ausgeführt (und ich find den Fehler nicht -.-)

  • VB.NET

Es gibt 4 Antworten in diesem Thema. Der letzte Beitrag () ist von der_Kurt.

    Sub wird 2 mal ausgeführt (und ich find den Fehler nicht -.-)

    Hallo...
    Ich hab hier en recht komischer Fehler....mit diesem Code (fertiger Dwonload mit webclient):

    VB.NET-Quellcode

    1. Private Sub dlfertig(ByVal sender As Object, ByVal e As System.ComponentModel.AsyncCompletedEventArgs) Handles downloader.DownloadFileCompleted
    2. If e.Cancelled = False Then
    3. Timer1.Stop()
    4. dekodieren(saveurl, Form1.settings(6) & "/" & Path.GetFileNameWithoutExtension(saveurl) & ".mp3")
    5. Else
    6. Exit Sub
    7. End If
    8. End Sub

    wird die Sub "dekodieren" 2 mal gestartet....dadurch wird FFMPEG natürlcih auch doppelt gestartet...

    An der Dekodieren-Sub kanns auch nicht liegen, da der Selbe Fehler auch bei nem anderen Programm vorkommt (und da trägts statt einem Listvew-item auch gleich 2 ein ) oO

    Ich hab zwar schon ne idee wie ich des Lösen könnt, aber eigentlich ist das doch nicht normal dass ein Download zweimal Fertig ist ^^

    Hoffe jemand weis ne Lösung (Außer beim DLfertig ereignis variable hochzählen lassen und dekodieren nur bei 0 ausführen oder so ähmlich :D)


    MfG Stefan

    VB.NET-Quellcode

    1. Imports System.Drawing
    2. 'Imports System.Management
    3. Imports System.Text.RegularExpressions
    4. Imports System.Net
    5. Imports System.Web
    6. Imports System.IO
    8. Public Class dekodownloadfenster
    9. Dim downrate As Integer = 0
    10. Dim oldfortschritt As Integer = 0
    11. Dim newfortschritt As Integer = 0
    12. Dim totalb As Integer = 0
    13. Dim recentb As Integer = 0
    14. Public request As HttpWebRequest
    15. Public request2 As HttpWebRequest
    16. Public response As HttpWebResponse
    17. Public source As String
    18. Public response2 As HttpWebResponse
    19. Public source2 As String
    20. Public WithEvents web As New WebClient
    21. Public downloadurl As String
    22. Delegate Sub OneArgD(ByVal arg As Object)
    23. Private MausLocation As Point
    24. Dim downloadbeendet As Boolean = True
    25. Dim vid As Integer = 1
    26. Public youtubeurl As String
    27. Public justvideo As Boolean = False
    28. Dim saveding As String
    29. Public CS_DROPSHADOW As Integer = 0
    30. Dim saveurl As String
    32. Private WithEvents downloader As WebClient
    36. Public Sub MakeDownloadURL(ByVal url As String, ByRef output As String, Optional ByRef type As String = "", Optional ByRef size As Integer = 0)
    37. 'PERFORMS CLEANUP
    38. downloadurl = ""
    39. If request IsNot Nothing Then
    40. Try
    41. request.Abort()
    42. Catch
    43. End Try
    44. End If
    45. If response IsNot Nothing Then
    46. Try
    47. response.Close()
    48. Catch
    49. End Try
    50. End If
    51. Try
    52. source = ""
    53. Catch
    54. End Try
    56. request = DirectCast(HttpWebRequest.Create(url.ToString), HttpWebRequest)
    57. Try
    58. response = DirectCast(request.GetResponse, HttpWebResponse)
    59. Catch
    60. type = ""
    61. Exit Sub
    62. End Try
    63. source = New StreamReader(response.GetResponseStream, System.Text.Encoding.Default).ReadToEnd
    65. If source.IndexOf("video_id") > -1 Then
    66. 'This grabs the .flv location URL ready for doownloading.
    67. Dim signature As String = source
    68. If signature.Contains("&fmt_url_map=") = True Then
    69. Try
    70. signature = System.Text.RegularExpressions.Regex.Split(signature, "&fmt_url_map=")(1)
    71. Catch
    72. End Try
    73. ElseIf signature.Contains(Chr(34) + "fmt_url_map" + Chr(34) + ": " + Chr(34)) = True Then
    74. Try
    75. signature = System.Text.RegularExpressions.Regex.Split(signature, Chr(34) + "fmt_url_map" + Chr(34) + ": " + Chr(34))(1)
    76. Catch
    77. End Try
    78. Else
    79. Debug.WriteLine("Critical Error: Download URL could not be produced.")
    80. type = ""
    81. Exit Sub
    82. End If
    84. 'This changes the URL to conform to internet standards eg. %20 = " "
    85. signature = signature.Remove(0, 5)
    86. signature = signature.Replace("%252C", ",")
    87. signature = signature.Replace("%2F", "/")
    88. signature = signature.Replace("%3D", "=")
    89. signature = signature.Replace("%3F", "?")
    90. signature = signature.Replace("%3A", ":")
    91. signature = signature.Replace("%26", "&")
    92. Dim sig2 As String = signature
    93. sig2 = sig2.IndexOf("http", 30)
    94. signature = signature.Remove(sig2, signature.Length - sig2)
    95. signature = signature.Remove(signature.IndexOf("%"), 7)
    96. 'Removes any remaining % characters from the string.
    97. signature = signature.Replace("%", "")
    99. 'Checks for and fixes any malformed http requests in the string.
    100. If signature.StartsWith("ttp://") Then
    101. signature = signature.Replace("ttp://", "http://")
    102. End If
    104. 'Checks for and Removes any remaining C characters from the string.
    105. If signature.Chars(signature.Length - 1) = "C" Then
    106. signature = signature.Remove(signature.Length - 1, 1)
    107. End If
    109. 'Checks for videos such as http://www.youtube.com/watch?v=LvLCvdeWcsw that would not download due to a new layout of download data.
    110. If signature.Contains("rv.2.rating") Then
    111. Dim n As Integer = signature.IndexOf(ChrW(34) + ",")
    112. signature = signature.Remove(n, signature.Length - n)
    113. End If
    115. 'PERFORMS CLEANUP
    116. If request2 IsNot Nothing Then
    117. Try
    118. request2.Abort()
    119. Catch
    120. End Try
    121. End If
    122. If response2 IsNot Nothing Then
    123. Try
    124. response2.Close()
    125. Catch
    126. End Try
    127. End If
    129. Try
    130. request2 = DirectCast(HttpWebRequest.Create(signature), HttpWebRequest)
    131. Catch
    132. type = ""
    133. Exit Sub
    134. End Try
    135. response2 = DirectCast(request2.GetResponse, HttpWebResponse)
    136. If response2.ContentType = "video/x-flv" Then
    137. type = ".flv"
    138. output = signature
    139. size = response2.ContentLength
    140. ElseIf response2.ContentType = "video/mp4" Then
    141. type = ".mp4"
    142. output = signature
    143. size = response2.ContentLength
    144. Else
    145. type = ""
    146. output = ""
    147. Exit Sub
    148. End If
    149. End If
    150. End Sub
    157. Private Sub dekodefenster_Load(ByVal sender As System.Object, ByVal e As System.EventArgs) Handles MyBase.Load
    158. Label1.Text = youtubeurl
    159. Me.ShowInTaskbar = True
    160. Me.Visible = True
    161. Dim tup
    162. downloadbeendet = True
    163. Dim filetype As String = ""
    164. Dim size As Integer = 0
    165. MakeDownloadURL(youtubeurl, downloadurl, filetype, size)
    167. If filetype = ".flv" Then
    168. tup = ".flv"
    169. ElseIf filetype = ".mp4" Then
    170. tup = ".mp4"
    171. Else
    172. MsgBox("An Error occured and the requested file(s) could not be downloaded." + vbCrLf + "This is normally caused by changes to the You-Tube Website.", MsgBoxStyle.Critical)
    173. Exit Sub
    174. End If
    176. ' Dim saveurl
    177. Label2.Text = downloadurl
    178. Dim webb As New WebBrowser
    179. webb.Navigate(youtubeurl)
    180. Do While Not webb.ReadyState = WebBrowserReadyState.Complete
    181. Application.DoEvents()
    182. Loop
    184. If Not My.Computer.FileSystem.DirectoryExists("C:\Taskload") Then
    185. My.Computer.FileSystem.CreateDirectory("C:\Taskload")
    186. End If
    187. Dim title As String = webb.DocumentTitle.Remove(0, 10)
    188. title = title.Replace("""", "")
    189. title = title.Replace("*", "")
    190. title = title.Replace("?", "")
    191. title = title.Replace("|", "")
    192. title = title.Replace(">", "")
    193. title = title.Replace("<", "")
    194. title = title.Replace("\", "")
    195. title = title.Replace("/", "")
    196. title = title.Replace(":", "")
    197. saveurl = Form1.videopfad & "\" & title & tup
    198. Label1.Text = "Lade " & webb.DocumentTitle.Remove(0, 10)
    199. webb.Navigate("http://google.de")
    201. laden(New Uri(downloadurl), saveurl)
    203. 'dekodieren(saveurl, Form1.settings(6) & "/" & Path.GetFileNameWithoutExtension(saveurl) & ".mp3")
    204. saveding = saveurl
    205. End Sub
    208. Public Sub dekodieren(ByVal input, ByVal output)
    210. Dim ffmpeg As New Process
    211. ffmpeg.StartInfo.FileName = Einstellungen.ffmpegpfad.Text 'PFAD ZU FFMPEG das musst du nacher halt noch umändern..... ähm aber dann startet er DEIN ffmpeg und das is am arsch :D ja ersetz doch einfach des ffmpeg oO im projekttordner ? achso...au
    212. 'ffmpeg.StartInfo.UseShellExecute = False
    213. 'ffmpeg.StartInfo.RedirectStandardError = True
    214. 'ffmpeg.StartInfo.RedirectStandardOutput = True
    215. 'ffmpeg.StartInfo.CreateNoWindow = True
    216. Dim blablabla As String = Einstellungen.TextBox1.Text
    217. blablabla = blablabla.Replace("%input%", input)
    219. blablabla = blablabla.Replace("%bitrate%", Einstellungen.audiioquali.Value)
    220. blablabla = blablabla.Replace("%output%", output)
    221. ffmpeg.StartInfo.Arguments = blablabla
    222. ffmpeg.Start()
    225. 'If input.Contains(".flv") = True Then
    226. ' 'FFmpeg.StartInfo.Arguments = "<--- Hier sollten die Startargumente hin für FLV... ich hab die immer benützt: siehe Komme unten drunter"
    227. ' '" -i " + input + " -ab 128 -f mp3 " + Path.Combine(outputfolder, Path.GetFileNameWithoutExtension(input) + ".mp3")
    228. ' ffmpeg.StartInfo.Arguments = " -i " + input + " -ab 128 -f mp3 " + output
    229. ' ' FFmpeg.StartInfo.Arguments = " -i " + input + " -ar 44100 -ac 2 -ab 128 " + Path.Combine(outputfolder, Path.GetFileNameWithoutExtension(input) + ".mp3")
    230. 'Else
    231. ' ffmpeg.StartInfo.Arguments = (" -i """ & input & """ -acodec libmp3lame -ab 320kb -ac 2 -ar 44100" & " " & "" & output)
    232. 'End If
    233. 'ffmpeg.Start()
    234. 'MsgBox("ffmpeg gestartet")
    235. ffmpeg.WaitForExit()
    238. ffmpeg.Close()
    239. Me.Close()
    240. End Sub
    249. Public Sub laden(ByVal dlurl As Uri, ByVal surl As String)
    250. downloader = New Net.WebClient
    251. AddHandler downloader.DownloadFileCompleted, AddressOf dlfertig
    252. AddHandler downloader.DownloadProgressChanged, AddressOf httpClient_DownloadProgressChanged
    253. downloader.DownloadFileAsync(dlurl, surl)
    254. Timer1.Start()
    255. ' Label1.Text = "Datei: " & saveurl.ToString
    256. End Sub
    259. Private Sub dlfertig(ByVal sender As Object, ByVal e As System.ComponentModel.AsyncCompletedEventArgs) Handles downloader.DownloadFileCompleted
    260. If e.Cancelled = False Then
    261. Timer1.Stop()
    263. dekodieren(saveurl, Form1.settings(6) & "/" & Path.GetFileNameWithoutExtension(saveurl) & ".mp3")
    264. Else
    265. 'laden(downlurl, saveurl)
    266. End If
    267. End Sub
    270. Private Sub httpClient_DownloadProgressChanged(ByVal sender As Object, _
    271. ByVal e As System.Net.DownloadProgressChangedEventArgs) _
    272. Handles downloader.DownloadProgressChanged
    275. With ProgressBar1
    276. .Value = e.ProgressPercentage
    278. End With
    280. ' KB-Fortschrittanzeige im Label
    281. Dim TotalBytes As Long = CLng(e.TotalBytesToReceive / 1024)
    282. Dim Bytes As Long = CLng(e.BytesReceived / 1024)
    283. If TotalBytes < 1 Then TotalBytes = 1
    284. If Bytes < 1 Then Bytes = 1
    285. recentb = Bytes
    286. totalb = TotalBytes
    287. newfortschritt = Bytes
    288. Label2.Text = Bytes.ToString & " KB von " & TotalBytes.ToString & " KB @ " & downrate & " kB/s" 'heruntergeladen." ' & e.UserState
    289. End Sub
    296. Private Sub Timer1_Tick(ByVal sender As System.Object, ByVal e As System.EventArgs) Handles Timer1.Tick
    297. downrate = newfortschritt - oldfortschritt
    300. ' Label2.Text = recentb.ToString & " KB von " & totalb.ToString & " KB @ " & abc & " kB/s" 'heruntergeladen." ' & e.UserState
    301. oldfortschritt = newfortschritt
    303. If downrate > My.Settings.rate Then
    304. My.Settings.rate = downrate
    305. Form1.maxdown.Text = My.Settings.rate & " kB/s"
    306. Form1.NotifyIcon1.Text = "Taskload - Höchste Downloadrate: " & My.Settings.rate & "kB/s"
    308. End If
    309. End Sub
    310. End Class



    Sehr viele kommentare :D

    Du hast ein Webclient-Objekt namens downloader mit "Withevents" deklariert...

    VB.NET-Quellcode

    1. Private WithEvents downloader As WebClient

    ...du hast demnach schon einen Handler, der das DownloadFileCompleted-Event bearbeitet.

    VB.NET-Quellcode

    1. Private Sub dlfertig(ByVal sender As Object, ByVal e As System.ComponentModel.AsyncCompletedEventArgs) Handles downloader.DownloadFileCompleted

    ...dennoch fügst du noch einen hinzu...?

    VB.NET-Quellcode

    1. downloader = New Net.WebClient
    2. AddHandler downloader.DownloadFileCompleted, AddressOf dlfertig


    Wenn du zweimal beim Pizza-Fritzen anrufst, gibt's zweimal Pizza.

    änliche thema: [VB 2010] Mehrfaches starten eines Prozesses verhindern (siehe lösung von Mono)

    @alex: warum gibst du schon wieder einen Link auf einen anderen Beitrag, wenn hier schon eine eigene Lösung vorliegt?